-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autotests): update use of unit_conversion to length_conversion and time_conversion #1282
fix(autotests): update use of unit_conversion to length_conversion and time_conversion #1282
Conversation
Could this PR be updated using a rebase instead of a merge. It's hard to tell what changes are unique to this PR. |
@langevin-usgs, I'm surprised it is showing up as a merge, I tried rebasing using the following command from a bash console I must not have pushed correctly. Sorry about this, I'll try again. |
b481c76
to
1b9eb20
Compare
1b9eb20
to
775fdb0
Compare
…d time_conversion
245d61c
to
b291ca9
Compare
A note on replacing the baked-in answers for the 4 SFR smoke tests that were updated with this%unitconv = this%unitconv * this%lengthconv**DONETHIRD Owing to the fact that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something doesn't seem quite right here. Shouldn't we be able to get the same results for the prudic problem? The simulated concentrations are quite different and don't match any more like they do here. I think we want to produce results that look more or less like this:
Or maybe I'm missing something?
b291ca9
to
8ede838
Compare
@langevin-usgs, it was me that was missing something. The factor 1.486 already reflected the fact that a cube root was applied to 3.28084, kind of embarrassing I didn't pick up on that before. I should've cubed 1.486 when I switched from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Eric, this looks much better. Only one final comment. Should length_conversion be more precisely specified as 3.28084 instead of the value that you use (3.281379)? It doesn't matter for the comparisons.
@langevin-usgs, I think this one is ready to go. I initially just cubed 1.486 with the thinking that's what was needed to get the autotests to pass, but as you point out, that wasn't necessary. They pass with the true |
Relates to #1154